dgb: embed-at-mint MM commitment into coinbase scriptSig (phase DB) - #477
Merged
Merged
Conversation
Wire the #475 dgb::coin::build_aux_mm_commitment SSOT into the per- connection coinbase assembler so a won DGB block, built as the DOGE merged-mining parent (-DAUX_DOGE=ON), carries the 44-byte AuxPoW MM tag (magic fabe6d6d || aux_root32 BE || size4 LE || nonce4 LE) the aux verifier decodes. ConnCoinbasePplnsInputs gains an optional aux_mm_commitment carrying the pre-built tag; build_connection_coinbase_from_pplns appends it to the coinbase scriptSig when present. DEFAULT nullopt leaves the scriptSig -- and therefore the whole gentx -- BYTE-IDENTICAL to the standalone-parent build: the no-op is structural, so the default V36 DGB build cannot regress. The producer (main_dgb seam) only ever populates the field under #ifdef AUX_DOGE; sourcing a LIVE aux merkle root is the gated DC routing slice and is deliberately not wired here. KAT (connection_coinbase_test, runs in both default and AUX_DOGE arms): E1 NulloptIsByteIdentical -- nullopt == no-aux gentx, txid-identical E2 AppendsMmTagToScriptSig -- gentx grows by EXACTLY 44 bytes, tag bytes match the #475 SSOT, scriptSig == baseline || tag 12/12 green both arms. Fenced to src/impl/dgb/; no ltc/doge tree edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase DB embed-at-mint live-wire. Stacks on #475 (consumes dgb::coin::build_aux_mm_commitment); retarget base->master after #475 merges.
What: ConnCoinbasePplnsInputs gains optional
aux_mm_commitment; build_connection_coinbase_from_pplns appends the pre-built 44-byte AuxPoW MM tag to the coinbase scriptSig when present, so a won DGB block built as the DOGE merged-mining parent (-DAUX_DOGE=ON) carries the commitment the aux verifier decodes.Byte-identical default no-op: nullopt (standalone V36 parent, and always when AUX_DOGE off since the producer only populates under #ifdef AUX_DOGE) leaves the scriptSig/gentx byte-identical -- structural, no regression to the default build.
Scope fence: src/impl/dgb/ only; zero ltc/doge tree edits. Live aux-root sourcing is the gated DC routing slice, NOT wired here (ltc-doge consumer-only [s=concur] + backend-exclusivity guard still OPEN).
Placement note for review: MM tag appended to coinbase scriptSig per AuxPoW convention / merged_mining.cpp:165-198 the #475 builder mirrors. Reviewers/ltc-doge: confirm against the aux verifier scriptSig decode path.
KAT (dgb_connection_coinbase_test, both default + AUX_DOGE arms, 12/12):
Consensus-bearing -> operator tap. No self-merge.